Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include lightgrep scanner results in "User-supplied regular expressions" #19

Closed
hannahlwang opened this issue Dec 12, 2019 · 1 comment

Comments

@hannahlwang
Copy link

Based on my review of BR, I would like to have results from the lightgrep scanner included in the “User-supplied regular expressions” filter in the Review Dashboard, which is currently limited to the results of the find scanner. It might also make sense to deduplicate these results, since the results of both scanners (if both are run) will be redundant.

@tw4l
Copy link
Member

tw4l commented Dec 13, 2019

Thank you, Hannah, and good timing! In Bulk Reviewer 0.2.0 (out today), features in both lightgrep.txt and find.txt map to "User-supplied regular expressions". If BR finds both lightgrep.txt and find.txt in the feature files directory, it will read only from lightgrep.txt, which should get rid of the duplicate results.

@tw4l tw4l closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants