You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the process of trying to get tests running for individual gems I discovered that we try to resolve config/models/roles.yml relative to the current working directory. Which meant that I ended up putting what's essentially a test fixture at bullet_train-incoming_webhooks/config/models/roles.yml just to keep the tests happy.
Ideally we'd resolve that file relative to Rails.root (if we haveRails.root) and the test file could then live in bullet_train-incoming_webhooks/test/dummy/config/models/roles.yml.
Here are at least a couple of spots where that resolution takes place, there may be more:
It looks like there are a couple of spots in the roles gem where we tried to get the test suite to look at the right place, but those don't seem to work.
In the process of trying to get tests running for individual gems I discovered that we try to resolve
config/models/roles.yml
relative to the current working directory. Which meant that I ended up putting what's essentially a test fixture atbullet_train-incoming_webhooks/config/models/roles.yml
just to keep the tests happy.Ideally we'd resolve that file relative to
Rails.root
(if we haveRails.root
) and the test file could then live inbullet_train-incoming_webhooks/test/dummy/config/models/roles.yml
.Here are at least a couple of spots where that resolution takes place, there may be more:
bullet_train-core/bullet_train-super_scaffolding/lib/scaffolding/transformer.rb
Lines 486 to 487 in 445b8e6
bullet_train-core/bullet_train-roles/lib/models/role.rb
Lines 7 to 8 in 445b8e6
It looks like there are a couple of spots in the
roles
gem where we tried to get the test suite to look at the right place, but those don't seem to work.bullet_train-core/bullet_train-roles/test/dummy/config/application.rb
Lines 34 to 35 in 445b8e6
bullet_train-core/bullet_train-roles/test/dummy/config/initializers/bullet_train-roles.rb
Lines 3 to 6 in 445b8e6
The text was updated successfully, but these errors were encountered: