Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq outputting tedious logs #380

Closed
gazayas opened this issue Aug 24, 2022 · 2 comments
Closed

Sidekiq outputting tedious logs #380

gazayas opened this issue Aug 24, 2022 · 2 comments
Assignees

Comments

@gazayas
Copy link
Contributor

gazayas commented Aug 24, 2022

After the new merges I'm getting these logs

worker           | Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
worker           |   redis.brpop("queue:critical", "queue:default", "queue:mailers", "queue:low", "queue:action_mailbox_routing", timeout: 2)(called from: /home/gazayas/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-6.5.5/lib/sidekiq/fetch.rb:49:in `block in retrieve_work')
worker           | Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
worker           |   redis.brpop("queue:critical", "queue:default", "queue:mailers", "queue:low", "queue:action_mailbox_routing", timeout: 2)(called from: /home/gazayas/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-6.5.5/lib/sidekiq/fetch.rb:49:in `block in retrieve_work')
worker           | Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
worker           |   redis.brpop("queue:critical", "queue:default", "queue:mailers", "queue:low", "queue:action_mailbox_routing", timeout: 2)(called from: /home/gazayas/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-6.5.5/lib/sidekiq/fetch.rb:49:in `block in retrieve_work')
worker           | Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
worker           |   redis.brpop("queue:critical", "queue:default", "queue:mailers", "queue:low", "queue:action_mailbox_routing", timeout: 2)(called from: /home/gazayas/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-6.5.5/lib/sidekiq/fetch.rb:49:in `block in retrieve_work')
worker           | Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
worker           |   redis.brpop("queue:critical", "queue:default", "queue:mailers", "queue:low", "queue:action_mailbox_routing", timeout: 2)(called from: /home/gazayas/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-6.5.5/lib/sidekiq/fetch.rb:49:in `block in retrieve_work')
worker           | Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
worker           |   redis.brpop("queue:critical", "queue:default", "queue:mailers", "queue:low", "queue:action_mailbox_routing", timeout: 2)(called from: /home/gazayas/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-6.5.5/lib/sidekiq/fetch.rb:49:in `block in retrieve_work')
worker           | Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
worker           |   redis.brpop("queue:critical", "queue:default", "queue:mailers", "queue:low", "queue:action_mailbox_routing", timeout: 2)(called from: /home/gazayas/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-6.5.5/lib/sidekiq/fetch.rb:49:in `block in retrieve_work')
worker           | Passing the timeout as a positional argument is deprecated, it should be passed as a keyword argument:
worker           |   redis.brpop("queue:critical", "queue:default", "queue:mailers", "queue:low", "queue:action_mailbox_routing", timeout: 2)(called from: /home/gazayas/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-6.5.5/lib/sidekiq/fetch.rb:49:in `block in retrieve_work')
worker           | Redis#sadd will always return an Integer in Redis 5.0.0. Use Redis#sadd? instead.(called from: /home/gazayas/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sidekiq-6.5.5/lib/sidekiq/launcher.rb:168:in `block (2 levels) in ❤')

At least there's a heart at the end? ❤️

@gazayas gazayas self-assigned this Aug 24, 2022
@gazayas
Copy link
Contributor Author

gazayas commented Aug 25, 2022

Already fixed on main according to an issue opened over at sidekiq yesterday. We just need to wait until the next version is released 👍

@gazayas
Copy link
Contributor Author

gazayas commented Sep 1, 2022

Fixed since merging in #391 which includes the update to Sidekiq 6.5.6.
Here's the main issue: sidekiq/sidekiq#5488

@gazayas gazayas closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant