Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't remove <% yield p = np %> from existing partial. #46

Closed
andrewculver opened this issue Jul 27, 2022 · 1 comment · Fixed by #47
Closed

Can't remove <% yield p = np %> from existing partial. #46

andrewculver opened this issue Jul 27, 2022 · 1 comment · Fixed by #47
Assignees
@kaspth

Comments

@andrewculver
Copy link
Contributor

Before:

Screen Shot 2022-07-26 at 7 52 19 PM

Steps to reproduce:

  1. Clone https://github.com/bullet-train-co/bullet_train
  2. Get it up and running (e.g. bin/setup, bin/dev, etc.)
  3. Run mkdir local; git clone git@github.com:bullet-train-co/nice_partials.git local/nice_partials
  4. Add gem "nice_partials", path: "local/nice_partials" to Gemfile
  5. Run bin/develop and select the bullet_train-themes-light Ruby gem.
  6. Open local/bullet_train-themes-light.
  7. Edit app/views/themes/light/_box.html.erb
  8. Remove <% yield p = np %>
  9. Experience bug.

After:

Screen Shot 2022-07-26 at 7 52 26 PM
@andrewculver andrewculver changed the title Can't remove <% yield p = np %>. Can't remove <% yield p = np %> from existing partial. Jul 27, 2022
@andrewculver
Copy link
Contributor Author

(Also, if I leave <% yield p = np %> in place, everything continues to work fine.)

@kaspth kaspth mentioned this issue Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaspth kaspth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix accessing partial before rendering leaks state bullet-train-co/nice_partials
2 participants
@andrewculver @kaspth