Image loads with stock, but can't be loaded with okhttp-integration

[TWiStErRob]

Glide Version/Integration library (if any): 3.6.0-SNAPSHOT, 1.3.0-SNAPTSHOT
Device/Android Version: S4/4.4
Issue details/Repro steps:
If you open this image in any browser or sane app on Laptop it gives HTTP 403. If you open it in Android Chrome or load using the stock android URLConnection it works, but not with okhttp-integration. They probably put a user-agent check there: confirmed with Chrome Dev Tools' device selector.
The weird thing is that the stock method is also using okhttp: com.android.okhttp.internal.http.HttpURLConnectionImpl, here's their setup I could fit on a screen:

Glide load line:

Glide
    .with(this)
    .load("http://img0.imgtn.bdimg.com/it/u=1892208653,1538092183&fm=21&gp=0.jpg")
    .placeholder(android.R.color.white)
    .error(android.R.color.black)
    .skipMemoryCache(true)
    .diskCacheStrategy(DiskCacheStrategy.NONE)
    .into(iv);

Stack trace:

04-22 19:48:06.513  16237-16237/net.twisterrob.app D/GenericRequest﹕ load failed
    java.io.IOException: Request failed with code: 403
            at com.bumptech.glide.integration.okhttp.OkHttpStreamFetcher.loadData(OkHttpStreamFetcher.java:43)
            at com.bumptech.glide.integration.okhttp.OkHttpStreamFetcher.loadData(OkHttpStreamFetcher.java:19)
            at com.bumptech.glide.load.model.ImageVideoModelLoader$ImageVideoFetcher.loadData(ImageVideoModelLoader.java:70)
            at com.bumptech.glide.load.model.ImageVideoModelLoader$ImageVideoFetcher.loadData(ImageVideoModelLoader.java:53)
            at com.bumptech.glide.load.engine.DecodeJob.decodeSource(DecodeJob.java:170)
            at com.bumptech.glide.load.engine.DecodeJob.decodeFromSource(DecodeJob.java:128)
            at com.bumptech.glide.load.engine.EngineRunnable.decodeFromSource(EngineRunnable.java:122)
            at com.bumptech.glide.load.engine.EngineRunnable.decode(EngineRunnable.java:101)
            at com.bumptech.glide.load.engine.EngineRunnable.run(EngineRunnable.java:58)
            at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422)
            at java.util.concurrent.FutureTask.run(FutureTask.java:237)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
            at java.lang.Thread.run(Thread.java:841)
            at com.bumptech.glide.load.engine.executor.FifoPriorityThreadPoolExecutor$DefaultThreadFactory$1.run(FifoPriorityThreadPoolExecutor.java:52)

[sjudd]

I'm not sure where to start here. I'm tempted to just say this is WAI? At least our behavior is consistent with chrome on Android?

[TWiStErRob]

Let me reiterate:

• Laptop Firefox: 403
• Laptop IE: 403
• Laptop Chrome: 403
• Android Chrome: works
• Glide with stock: works
• Glide with okhttp: 403
• Laptop Chrome with UA emulation (Android): works

So okhttp-integration doesn't tell the webserver that we're on mobile.
I think this could be tackled by comparing the stock (which uses com.android.okhttp.internal.http.HttpURLConnectionImpl) and the integration's okhttp connection setup (this is why I included the image, but I didn't have time to do the okhttp at that time).

[sjudd]

Ah ok I see what you're saying, thanks. I'll take a look.

[TWiStErRob]

I also didn't check how volley behaves.

[sjudd]

Any chance you could test this locally? It looks like you get a default user agent from system properties, which we could set if no user agent is set in the headers. For example:

String userAgent = System.getProperty( "http.agent" );
requestBuilder.addHeader("User-Agent", userAgent);

http://stackoverflow.com/questions/4103963/is-there-a-way-to-obtain-the-default-user-agent-string-aside-from-webview-getset

[sjudd]

Actually nevermind, I'll try this myself.

[TWiStErRob]

I put a breakpoint there and executed the code you quoted and it loads with okhttp.

[sjudd]

ok great thanks!

[TWiStErRob]

Volley uses AndroidHttpClient probably, so that makes it work somehow (didn't find it exactly).

[Edijae]

where do i add

String userAgent = System.getProperty( "http.agent" );
requestBuilder.addHeader("User-Agent", userAgent);

it does not fit here

public class OkHttpProgressGlideModule  implements GlideModule {

    @Override
    public void applyOptions(Context context, GlideBuilder builder) {
        builder.setDecodeFormat(DecodeFormat.ALWAYS_ARGB_8888);
    }


    @Override
    public void registerComponents(Context context, Glide glide) {
        OkHttpClient client = new OkHttpClient.Builder()
                .addInterceptor(createInterceptor(new DispatchingProgressListener()))
                .build();
        glide.register(GlideUrl.class, InputStream.class, new OkHttpUrlLoader.Factory(client));
    }

[TWiStErRob]

@gikarasojo you don't need to add it anywhere, it's included in the 3.7.0 release.

If you want to apply global headers, configure the OkHttpClient; or if you want certain requests only, create a GlideUrl with LazyHeaders where you start the load.

[Edijae]

@TWiStErRob am using firebase and i want to download an image from my firebase storage. i just want to download an image with custom sizes, therefore i have this class

public class MyUriLoader extends BaseGlideUrlLoader<MyDataModel> {

  public MyUriLoader(Context context) {
    super(context);
  }

  @Override
  protected String getUrl(MyDataModel model, int width, int height) {
    // Construct the url for the correct size here.
    return model.buildUrl(width, height);
  }
}

and i download like this

Glide.with(context)
      .using(new MyUriLoader(context))
      .load(new CustomImageSize(item.getPhotoUri()))
      .asBitmap()
      .centerCrop()
      .into(holder.target);

am using OkHttpClient for purposes of showing percentage downloaded. it's working fine when i paste an image uri from google but throwing an error when i try to download from firebase storage

load failed
   java.io.IOException: Request failed with code: 403
     at com.bumptech.glide.integration.okhttp3.OkHttpStreamFetcher.loadData(OkHttpStreamFetcher.java:46)
                                                                              at com.bumptech.glide.integration.okhttp3.OkHttpStreamFetcher.loadData(OkHttpStreamFetcher.java:19)
                                                                              at com.bumptech.glide.load.model.ImageVideoModelLoader$ImageVideoFetcher.loadData(ImageVideoModelLoader.java:70)
                                                                              at com.bumptech.glide.load.model.ImageVideoModelLoader$ImageVideoFetcher.loadData(ImageVideoModelLoader.java:53)

[Edijae]

@TWiStErRob Is there a better way to show percentage download in glide?

[TWiStErRob]

You very likely need to use authenticated access for Firebase, but that's another issue unrelated to this one. Search for "Glide firebase", and open a new issue if you want help. I used OkHttp to show progress.