Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomTarget width & height parameter is PX or DP? #4989

Closed
flamyoad opened this issue Dec 30, 2022 · 0 comments · Fixed by #4990
Closed

CustomTarget width & height parameter is PX or DP? #4989

flamyoad opened this issue Dec 30, 2022 · 0 comments · Fixed by #4990

Comments

@flamyoad
Copy link

flamyoad commented Dec 30, 2022

    Glide.with(context)
        .asDrawable()
        .load(imageUrl)
        .into(object: CustomTarget<Drawable>(32, 32) { // <--- This is in dp or px?
            override fun onResourceReady(resource: Drawable, transition: Transition<in Drawable>?) {
                 // no-op
            }
            override fun onLoadCleared(placeholder: Drawable?) {
                // no-op
            }
        })

As titled, the constructor for CustomTarget accepts width and height as the requested size. But it did not mention if they should be px or dp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant