Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the need of selenium for bundesanzeiger, to ship less and more portable code #11

Merged
merged 4 commits into from Aug 11, 2021

Conversation

K0IN
Copy link
Contributor

@K0IN K0IN commented Aug 10, 2021

I rewrote bundesanzeiger to use requests instead of selenium, this should boost performance and portability.

Note: I could not get the normal branch to work properly, so I did not fully cross-check the output.

* Removed debug line
* Removed unused dependencies
@LilithWittmann
Copy link
Member

Oh wow. Thank you so much. One question: Do you maybe want to add an integration test with pytest or something similar? So we can track automatically if it is still working in the future or if they found a way to block it. 🙃 (I mainly used selenium because usually it gets harder to block…)

@K0IN
Copy link
Contributor Author

K0IN commented Aug 10, 2021

Oh wow. Thank you so much. One question: Do you maybe want to add an integration test with pytest or something similar? So we can track automatically if it is still working in the future or if they found a way to block it. 🙃 (I mainly used selenium because usually it gets harder to block…)

Ye sure I can add some tests as well

* Added Github pipeline
* Added test to check if api returns more the one report
* Fixed some formating
* Removed Selenium banner from readme
* fixed linting problem
* fixed wrong py version
@LilithWittmann LilithWittmann merged commit 067828c into bundesAPI:main Aug 11, 2021
@LilithWittmann
Copy link
Member

Danke 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants