log gemspec load failures and continue

this should produce useful logs instead of crashing while the nightly sync task is running
rubygems · Aug 21, 2016 · 483305a · 483305a
1 parent 5b30df3
commit 483305a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/lib/bundler_api/gem_helper.rb b/lib/bundler_api/gem_helper.rb
@@ -31,6 +31,9 @@ def download_spec
     @mutex.synchronize do
       @gemspec ||= Marshal.load(Gem.inflate(fetch(url)))
     end
+  rescue => e
+    STDERR.puts "[Error] Downloading gemspec #{full_name} failed! #{e.class}: #{e.message}"
+    STDERR.puts e.backtrace.join("\n  ")
   end
 
   def download_checksum

diff --git a/lib/bundler_api/update/job.rb b/lib/bundler_api/update/job.rb
@@ -27,7 +27,10 @@ def run
     return if @db_helper.exists?(@payload) && !@fix_deps
     return if !@db_helper.exists?(@payload) && @fix_deps
     log "Adding: #{@payload.full_name}\n"
+
     spec = @payload.download_spec
+    return unless spec
+
     checksum = @payload.download_checksum unless @fix_deps
     @mutex.synchronize do
       deps_added = insert_spec(spec, checksum)