Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Commit

Permalink
Merge tag 'v1.10.6'
Browse files Browse the repository at this point in the history
Version 1.10.6

# Conflicts:
#	lib/bundler/cli.rb
#	lib/bundler/source/git/git_proxy.rb
#	spec/install/parallel/spec_installation_spec.rb
  • Loading branch information
segiddins committed Jul 22, 2015
2 parents 8d25615 + a85578c commit c784ea3
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 7 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,15 @@
## 1.10.6 (2015-07-22)

Workarounds:

- only warn on invalid gemspecs (@indirect)

Bugfixes:

- fix installing dependencies in the correct order (#3799, @pducks32)
- fix sorting of mixed DependencyLists (#3762, @tony-spataro-rs)
- fix `install_if` conditionals when using the block form (@danieltdt)

## 1.10.5 (2015-06-24)

Workarounds:
Expand Down
3 changes: 2 additions & 1 deletion lib/bundler.rb
Expand Up @@ -385,8 +385,9 @@ def load_gemspec_uncached(file, validate = false)
spec
end
rescue Gem::InvalidSpecificationException => e
raise InvalidOption, "The gemspec at #{file} is not valid. " \
Bundler.ui.warn "The gemspec at #{file} is not valid. " \
"The validation error was '#{e.message}'"
nil
end

def clear_gemspec_cache
Expand Down
2 changes: 1 addition & 1 deletion lib/bundler/cli.rb
Expand Up @@ -351,7 +351,7 @@ def viz
:lazy_default => [ENV["BUNDLER_EDITOR"], ENV["VISUAL"], ENV["EDITOR"]].find {|e| !e.nil? && !e.empty? },
:desc => "Open generated gemspec in the specified editor (defaults to $EDITOR or $BUNDLER_EDITOR)"
method_option :ext, :type => :boolean, :default => false, :desc => "Generate the boilerplate for C extension code"
method_option :mit, :type => :boolean, :desc => "Generate an MIT license file"
method_option :mit, :type => :boolean, :desc => "Generate an MIT license file. Set a default with `bundle config gem.mit true`."
method_option :test, :type => :string, :lazy_default => "rspec", :aliases => "-t", :banner => "rspec",
:desc => "Generate a test directory for your library, either rspec or minitest. Set a default with `bundle config gem.test rspec`."
def gem(name)
Expand Down
2 changes: 1 addition & 1 deletion lib/bundler/source/git/git_proxy.rb
Expand Up @@ -84,7 +84,7 @@ def copy_to(destination, submodules = false)
FileUtils.mkdir_p(destination.dirname)
FileUtils.rm_rf(destination)
git_retry %|clone --no-checkout --quiet "#{path}" "#{destination}"|
File.chmod((0777 & ~File.umask), destination)
File.chmod(((File.stat(destination).mode | 0777) & ~File.umask), destination)
rescue Errno::EEXIST => e
file_path = e.message[/.*?(\/.*)/, 1]
raise GitError, "Bundler could not install a gem because it needs to " \
Expand Down
2 changes: 1 addition & 1 deletion lib/bundler/templates/newgem/README.md.tt
Expand Up @@ -26,7 +26,7 @@ TODO: Write usage instructions here

## Development

After checking out the repo, run `bin/setup` to install dependencies.<% if config[:test] %> Then, run `rake <%= config[:test].sub('mini', '') %>` to run the tests.<% end %> You can also run `bin/console` for an interactive prompt that will allow you to experiment.<% if config[:bin] %> Run `bundle exec <%= config[:name] %>` to use the gem in this directory, ignoring other installed copies of this gem.<% end %>
After checking out the repo, run `bin/setup` to install dependencies.<% if config[:test] %> Then, run `rake <%= config[:test].sub('mini', '').sub('rspec', 'spec') %>` to run the tests.<% end %> You can also run `bin/console` for an interactive prompt that will allow you to experiment.<% if config[:bin] %> Run `bundle exec <%= config[:name] %>` to use the gem in this directory, ignoring other installed copies of this gem.<% end %>

To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).

Expand Down
2 changes: 1 addition & 1 deletion lib/bundler/version.rb
Expand Up @@ -2,5 +2,5 @@ module Bundler
# We're doing this because we might write tests that deal
# with other versions of bundler and we are unsure how to
# handle this better.
VERSION = "1.10.5" unless defined?(::Bundler::VERSION)
VERSION = "1.10.6" unless defined?(::Bundler::VERSION)
end
4 changes: 2 additions & 2 deletions spec/install/gemfile/path_spec.rb
Expand Up @@ -141,7 +141,7 @@
should_be_installed "premailer 1.0.0"
end

it "errors on invalid specs", :rubygems => "1.7" do
it "warns on invalid specs", :rubygems => "1.7" do
build_lib "foo"

gemspec = lib_path("foo-1.0").join("foo.gemspec").to_s
Expand All @@ -158,7 +158,7 @@
G

expect(out).to match(/missing value for attribute version/)
should_not_be_installed("foo 1.0")
expect(out).to_not include("ERROR REPORT")
end

it "supports gemspec syntax" do
Expand Down

0 comments on commit c784ea3

Please sign in to comment.