HTTP Proxy with Authentication not handled correctly

[tbuehlmann]

Got into the situation having an HTTP Proxy with Authentication. The environment variable http_proxy was set correctly, but Bundler failed on installing with the source 'https://rubygems.org' with a Network error when fetching a gem and an HTTP Proxy Auth Error on 'http://rubygems.org'. Though I was able to install one gem per bundle install with the http-source before getting the error.

The error is reproducible and has to do with the HTTP Proxy username. In my case it contained an escaped @ character, a %40. When having that in the HTTP Proxy setting, Bundler will first use the correct setting and later (somehow) switch to the unescaped @-version.

Here's a gist to reproduce the error: https://gist.github.com/tbuehlmann/8023219

[tbuehlmann]

This is caused by not escaping HTTP Proxy usernames and passwords in the vendored net/http/persistent library. It's fixed in the original code, so we need to vendor the new version.

[indirect]

Happy to accept a pull request to do that.

[tbuehlmann]

Opened #2912, closing this one.