Refactoring config.rb #4047
Refactoring config.rb #4047
Conversation
My main goal was to show the structure of the run method: 1. Guard Clauses 2. Message to user 3. Save new settings and to separate the message texts from the rest of the logic. So the class and methods are easier to understand read. While doing that I reduced the complexity of the run method by extracting methods. This should improve the Code Climate rating of Bundler::CLI::Config substantially.
|
This will probably conflict with @smlance's 2.0 work? |
|
Hmm. Seems like Travis has stopped for some reason. Some builds never started one says something about git clone failing. Should I do some random change and push again or is there a better way to restart the build process? |
|
I just restarted the build. Hopefully it'll pass this time. |
|
Thanks @indirect! |
|
@homu r+ |
|
📌 Commit 4b7d61b has been approved by |
Refactoring config.rb My main goal was to show the structure of the run method: 1. Guard Clauses 2. Message to user 3. Save new settings and to separate the message texts from the rest of the logic. So the class and methods are easier to understand read. While doing that I reduced the complexity of the run method by extracting methods. This should improve the Code Climate rating of Bundler::CLI::Config substantially.
|
@indirect is this you volunteering to reconcile this PR with the changes on 2-0-dev? |
|
@segiddins yup 😆 |
|
☀️ Test successful - status |
|
@indirect Thanks! I hope this isn't causing too much merge pains... If I can help with the reconciliation somehow I'd be happy to. |
|
@A5308Y I'm very happy to work with you on refactorings :) We will have to work with this code base for a long time, so I'd rather do the work of cleaning it up and then porting those cleanups to the 2.0 branch than wait for 2.0 to be finished first. You can definitely ask in Slack, but feel free to send PRs for sure. |
|
@indirect Cool :-) Thanks for making it so easy to get involved! |
My main goal was to show the structure of the run method:
and to separate the message texts from the rest of the logic.
So the class and methods are easier to understand read.
While doing that I reduced the complexity of the run method by
extracting methods. This should improve the Code Climate rating of
Bundler::CLI::Config substantially.