Conversation
module Bundler | ||
WINDOWS = RbConfig::CONFIG["host_os"] =~ %r!(msdos|mswin|djgpp|mingw)! | ||
FREEBSD = RbConfig::CONFIG["host_os"] =~ /bsd/ | ||
NULL = WINDOWS ? "NUL" : "/dev/null" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File::NULL
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File::NULL
isn't available on Ruby 1.8.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use Bundler::NULL, which already does the platform checking. This patch looks great, and I hope to turn on parallel installation by default in a future release.
On Wed, May 22, 2013 at 11:24 PM, Kenta Murata notifications@github.com
wrote:
@@ -0,0 +1,5 @@
+module Bundler
- WINDOWS = RbConfig::CONFIG["host_os"] =~ %r!(msdos|mswin|djgpp|mingw)!
- FREEBSD = RbConfig::CONFIG["host_os"] =~ /bsd/
- NULL = WINDOWS ? "NUL" : "/dev/null"
File::NULL
isn't available on Ruby 1.8.x.
Reply to this email directly or view it on GitHub:
https://github.com/bundler/bundler/pull/2481/files#r4354668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using File:NULL
if available is more portable than the current Bundler::NULL
:
NULL = defined?(File::NULL) ? File::NULL : WINDOWS ? "NUL" : "/dev/null"
I made an improvement to the behavior when some gem's installation fails. |
Excellent. Are partially installed gems cleaned up? Since the Bundler default is to install into GEM_HOME, I would like to avoid leaving partially installed gems for Rubygems to find later. On Wed, Jun 5, 2013 at 12:44 AM, eagletmt notifications@github.com
|
The |
Sounds like that should be fine. :) On Wed, Jun 5, 2013 at 6:54 PM, eagletmt notifications@github.com wrote:
|
Last comment 14 days ago. @eagletmt have you run into any blockers? Where are we with this PR? |
@schneems I haven't had time to review and test this yet :( But it passes on travis, which is an extremely promising sign. You want to try this out while building a slug for a big app? That would be a super useful data point. |
My PR has no effect unless |
🤘 |
it's awesome!!! 👍 👍 👍 |
👍 Sweet! |
Hi. This is wonderful. Is it possible to make this the default via a config file and not have to type the flag each time? Thanks |
In the master branch, this option is remembered, and can also be set via On Sep 4, 2013, at 2:17 AM, Jérémy Lecour notifications@github.com wrote:
|
👍 nice idea |
Awesome! 👍 |
This is awesome. 👍 |
Could we also add this to bundle update as well? |
Sounds good, anyone want to send a pull request adding this to update? |
It can be realized to adding the option entry of |
Watching this |
You don’t need to comment to watch things. Please don’t. On Oct 31, 2013, at 5:14 PM, Claudio Poli notifications@github.com wrote:
|
I parallelized gem installation. It mainly improves initial
bundle install
speed.I added a new option
-j
which specifies the number of jobs to run in parallel.The parallelization mechanism is normally multi-process using
fork
, but it switches to multi-thread on Windows because it doesn't havefork
. Multi-thread version is slower than multi-process version due to locking aboutDir.chdir
.At one project, which have over 200 gems to be installed, initial
bundle -j4
is faster thanbundle
by about four minutes.