Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Allow require: true as an alias for require: <name> #2538

Merged
merged 1 commit into from Jul 18, 2013
Merged

Allow require: true as an alias for require: <name> #2538

merged 1 commit into from Jul 18, 2013

Conversation

ndbroadbent
Copy link
Contributor

Here's my use-case:

# Don't require debugger if using RubyMine
gem 'debugger', require: !ENV['RM_INFO']

Currently we have to write:

gem 'debugger', require: (ENV['RM_INFO'] ? false : 'debugger')

or

gem 'debugger', {}.merge(ENV['RM_INFO'] ? {require: false} : {})

@ixti
Copy link
Contributor

ixti commented Jul 13, 2013

👍

1 similar comment
@mcmire
Copy link

mcmire commented Jul 14, 2013

👍

@gnufied
Copy link
Contributor

gnufied commented Jul 16, 2013

+1 the only thing left is - can you update gemfile.5.ronn @ndbroadbent . We should be happy to merge it after that. /cc @indirect

gnufied pushed a commit that referenced this pull request Jul 18, 2013
Merge pull request #2538 from ndbroadbent/allow_require_true
d2678b1 
Allow `require: true` as an alias for `require: <name>`
@gnufied gnufied merged commit d2678b1 into rubygems:master Jul 18, 2013
simi added a commit to simi/bundler that referenced this pull request Jul 18, 2013
@simi
PR rubygems#2538 (allow require: true as an alias for `require: <na…
2e3473c 
…me>`) CHANGELOG entry

[ci skip]
@simi simi mentioned this pull request Jul 18, 2013
Merged
indirect added a commit that referenced this pull request Jul 18, 2013
@indirect
Merge pull request #2547 from simi/require_true_changelog
bdec9ea 
PR #2538 (allow `require: true` as an alias for `require: <name>`) CHANGELOG entry
@gnufied gnufied mentioned this pull request Sep 17, 2013
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ndbroadbent @ixti @mcmire @gnufied