Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Show friendly errors when ref is not found #3965

Merged
merged 1 commit into from Aug 27, 2015
Merged

Show friendly errors when ref is not found #3965

merged 1 commit into from Aug 27, 2015

Conversation

agis
Copy link
Contributor

@agis agis commented Aug 26, 2015

Before:

$ bundle install
Fetching git://github.com/agis-/some_gem.git
fatal: ambiguous argument 'FOO': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'
Git error: command `git rev-parse WRONG` in directory /cache/path
has failed.
Ref 'foo' was not found. Perhaps you mispelled it?
If this error persists you could try removing the cache directory
# ...

After:

$ bundle install
Fetching git://github.com/agis-/some_gem.git
fatal: Needed a single revision
Git error: command `git rev-parse --verify WRONG` in directory /cache/path
has failed.
Ref 'foo' was not found. Perhaps you mispelled it?
If this error persists you could try removing the cache directory
# ...

Fixes #3879.

Before:

    $ bundle install
    Fetching git://github.com/agis-/some_gem.git
    fatal: ambiguous argument 'FOO': unknown revision or path not in the working tree.
    Use '--' to separate paths from revisions, like this:
    'git  [...] -- [...]'
    Git error: command `git rev-parse WRONG` in directory /cache/path
    has failed.
    Ref 'foo' was not found. Perhaps you mispelled it?
    If this error persists you could try removing the cache directory
    # ...

After:

    $ bundle install
    Fetching git://github.com/agis-/some_gem.git
    fatal: Needed a single revision
    Git error: command `git rev-parse --verify WRONG` in directory /cache/path
    has failed.
    Ref 'foo' was not found. Perhaps you mispelled it?
    If this error persists you could try removing the cache directory
    # ...

Closes #3897.
@indirect
Copy link
Member

Looks good to me. @homu r+

@homu
Copy link
Contributor

homu commented Aug 27, 2015

📌 Commit b8da6a9 has been approved by indirect

@homu
Copy link
Contributor

homu commented Aug 27, 2015

⌛ Testing commit b8da6a9 with merge fa9c4e2...

homu added a commit that referenced this pull request Aug 27, 2015
Show friendly errors when ref is not found

Before:

    $ bundle install
    Fetching git://github.com/agis-/some_gem.git
    fatal: ambiguous argument 'FOO': unknown revision or path not in the working tree.
    Use '--' to separate paths from revisions, like this:
    'git  [...] -- [...]'
    Git error: command `git rev-parse WRONG` in directory /cache/path
    has failed.
    Ref 'foo' was not found. Perhaps you mispelled it?
    If this error persists you could try removing the cache directory
    # ...

After:

    $ bundle install
    Fetching git://github.com/agis-/some_gem.git
    fatal: Needed a single revision
    Git error: command `git rev-parse --verify WRONG` in directory /cache/path
    has failed.
    Ref 'foo' was not found. Perhaps you mispelled it?
    If this error persists you could try removing the cache directory
    # ...

Fixes #3879.
@homu
Copy link
Contributor

homu commented Aug 27, 2015

☀️ Test successful - status

@homu homu merged commit b8da6a9 into rubygems:master Aug 27, 2015
@coilysiren coilysiren modified the milestone: Release Archive Oct 9, 2016
@agis agis deleted the issue-3879 branch January 23, 2017 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants