This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Switch autoload to require source in plugin/api
#5379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally a workaround fix in rubygems#5010, to prevent the following error in fastlane and rdoc on bundler 1.14.3, but the following commit undid this, and this errors is reappearing: rubygems@6167ec8 ``` gems/bundler-1.14.3/lib/bundler/rubygems_ext.rb:45:in `full_gem_path': uninitialized constant Bundler::Plugin::API::Source (NameError) from /lib/ruby/site_ruby/2.0.0/rubygems/basic_specification.rb:144:in `block in full_require_paths' ``` This commit will revert that change.
|
This is a performance regression. Please add a test for the issue this is fixing and we'll try and come up with another fix. |
|
Hi Sam, This is happening at the basic gem loading, and as in spite of how long I've been doing RoR, I have never had to write a test at that low level, particularly when this appears to be a very interdependent case with fastlane or sdoc (I'm doing the latter). It appears that upon loading the bundler gem, specifically when running from sdoc, we're hitting the line in I did a stack trace to see who/how it was being called, and found that interestingly, that line is being called twice, and the first time it is being called, the I hope this helps in identifying the source of the problem: |
|
How do I reproduce this issue? |
|
install the sdoc gem ( |
|
I'm unable to replicate this error. Can you provide more details of your environment with |
|
Hi, Does this help? Looks like we're on the same env, roughly... |
|
Can you update your version of rubygems |
|
thank you for the suggestion - i'll have to find a machine that i can reset with a fresh install - i've found that updating rubygems often has a large trickle-on effect. cheers |
|
I can't reproduce this on either RubyGems 2.6.10 or 2.4.8 |
|
ping @btsai |
|
This should no longer be required as of 1.14.6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not use
autoload :Source, "bundler/plugin/api/source"in plugin/api as this breaks sdoc, fastlane with this error:Thank you for merging in and putting out new gem!