Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Fix bundle outdated --local. It's supposed to use local cache to dete… #5483

Merged
merged 2 commits into from Feb 28, 2017
Merged

Fix bundle outdated --local. It's supposed to use local cache to dete… #5483

merged 2 commits into from Feb 28, 2017

Conversation

denniss
Copy link
Contributor

@denniss denniss commented Feb 28, 2017 •
edited by segiddins

Fixes #5430

@denniss denniss changed the title Fix bundle autoload --local. It's supposed to use local cache to dete… Fix bundle outdated --local. It's supposed to use local cache to dete… Feb 28, 2017
segiddins
segiddins reviewed Feb 28, 2017
View reviewed changes
Copy link
Member

@segiddins segiddins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

spec/commands/outdated_spec.rb Outdated
@@ -187,6 +187,21 @@ def test_group_option(group = nil, gems_list_size = 1)
end

describe "with --local option" do
it "uses local cache to return a list of outdated gems" do
update_repo2 do
build_gem 'activesupport', '2.3.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double quotes

@denniss
Copy link
Contributor Author

denniss commented Feb 28, 2017

Thanks for the review

@segiddins segiddins added this to the 1.14.6 milestone Feb 28, 2017
@segiddins
Copy link
Member

Thanks!
@bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit a14bec0 has been approved by segiddins

@bundlerbot
Copy link
Collaborator

⌛ Testing commit a14bec0 with merge 0b25fae...

bundlerbot added a commit that referenced this pull request Feb 28, 2017
@bundlerbot
Auto merge of #5483 - denniss:5430-fix-bundle-outdated-local, r=segid…
0b25fae 
…dins

Fix bundle outdated --local. It's supposed to use local cache to dete…

Fixes #5430
@bundlerbot
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: segiddins
Pushing 0b25fae to master...

@bundlerbot bundlerbot merged commit a14bec0 into rubygems:master Feb 28, 2017
segiddins pushed a commit that referenced this pull request Mar 3, 2017
@bundlerbot @segiddins
Auto merge of #5483 - denniss:5430-fix-bundle-outdated-local, r=segid…
4611872 
…dins

Fix bundle outdated --local. It's supposed to use local cache to dete…

Fixes #5430

(cherry picked from commit 0b25fae)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@segiddins segiddins segiddins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@denniss @segiddins @bundlerbot