This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[Pristine] Allow passing a list of gems to pristine #5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to print a warning to the user if they're giving a gem not in the Gemfile? Otherwise this LGTM |
|
@colby-swandale done |
segiddins
force-pushed
the
seg-pristine-specific-gems
branch
from
efc7a4e
to
922ef03
Compare
|
🎉 @bundlerbot r+ |
|
📌 Commit 922ef03 has been approved by |
colby-swandale
approved these changes
Jun 15, 2017
bundlerbot
added a commit
that referenced
this pull request
Jun 15, 2017
…ndale [Pristine] Allow passing a list of gems to pristine In the process of testing this, I discovered and fixed a bug that had pristine git gems not get added files removed.
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of testing this, I discovered and fixed a bug that had pristine git gems not get added files removed.