Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Puma dependency to ~> 3.10 #169

Merged
merged 1 commit into from Sep 12, 2017
Merged

Conversation

premist
Copy link
Contributor

@premist premist commented Sep 12, 2017

Tried to install Puma on freshly installed Arch Linux instance failed since older version of Puma doesn't support latest OpenSSL version(related issue).

This PR updates Puma dependency to the latest available version, 3.10. Newer version of Puma introduced some changes to Puma::CLI interface, so I also updated integration test to reflect it.

@olleolleolle
Copy link
Member

@premist Interesting crash on JRuby; different than other crashes.

Idea: Can you change the "dist" in .travis.yml to be trusty instead?

@olleolleolle
Copy link
Member

I did that change in #167, and it did the trick for the build, in general.

We shall see how it fares with this core-dump.

@indirect
Copy link
Member

indirect commented Sep 12, 2017

We'll probably want to rebase this on top of master now that #167 has landed and see if that fixes the build?

@olleolleolle
Copy link
Member

@premist Now you can rebase on master to retry.

@olleolleolle
Copy link
Member

olleolleolle commented Sep 12, 2017

@indirect Can you retry the Travis build?

One of the builds did pass, the other hung on the "large data" case.

https://github.com/bundler/gemstash/blob/25d89b77dc1273bf0f54aa1a249f338676ddc77a/spec/concurrency_spec.rb#L95-L99

@olleolleolle
Copy link
Member

\o/

@olleolleolle
Copy link
Member

@bundlerbot r+

@bundlerbot
Copy link
Contributor

📌 Commit 9b58d68 has been approved by olleolleolle

@bundlerbot
Copy link
Contributor

⌛ Testing commit 9b58d68 with merge d34fc8f...

bundlerbot added a commit that referenced this pull request Sep 12, 2017
Update Puma dependency to ~> 3.10

Tried to install Puma on freshly installed Arch Linux instance failed since older version of Puma doesn't support latest OpenSSL version([related issue](puma/puma#1380)).

This PR updates Puma dependency to the latest available version, 3.10. Newer version of Puma introduced some changes to Puma::CLI interface, so I also updated integration test to reflect it.
@bundlerbot
Copy link
Contributor

💔 Test failed - status-travis

@olleolleolle
Copy link
Member

@bundlerbot retry

bundlerbot added a commit that referenced this pull request Sep 12, 2017
Update Puma dependency to ~> 3.10

Tried to install Puma on freshly installed Arch Linux instance failed since older version of Puma doesn't support latest OpenSSL version([related issue](puma/puma#1380)).

This PR updates Puma dependency to the latest available version, 3.10. Newer version of Puma introduced some changes to Puma::CLI interface, so I also updated integration test to reflect it.
@bundlerbot
Copy link
Contributor

⌛ Testing commit 9b58d68 with merge c0fe71f...

@bundlerbot
Copy link
Contributor

💔 Test failed - status-travis

@olleolleolle
Copy link
Member

@bundlerbot retry

@bundlerbot
Copy link
Contributor

⌛ Testing commit 9b58d68 with merge 2a21805...

bundlerbot added a commit that referenced this pull request Sep 12, 2017
Update Puma dependency to ~> 3.10

Tried to install Puma on freshly installed Arch Linux instance failed since older version of Puma doesn't support latest OpenSSL version([related issue](puma/puma#1380)).

This PR updates Puma dependency to the latest available version, 3.10. Newer version of Puma introduced some changes to Puma::CLI interface, so I also updated integration test to reflect it.
@bundlerbot
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: olleolleolle
Pushing 2a21805 to master...

@bundlerbot bundlerbot merged commit 9b58d68 into rubygems:master Sep 12, 2017
@premist premist deleted the update-puma branch September 13, 2017 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants