Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few tweaks: enable setting the host to bind to, and reduced access for some attributes #28

Merged
merged 3 commits into from Oct 13, 2015

Conversation

pcarranza
Copy link
Contributor

Mainly because I am running gemstash in a host on with a public IP, I don't want it to be a public mirror.

@pcarranza
Copy link
Contributor Author

BTW cc @smellsblue

@smellsblue
Copy link
Contributor

👍 though how about the bind have the tcp:// and port baked into the option rather than the host and port separate used to put it in?

That way, if someone wants to bind it on a unix socket and wrap it in an nginx/apache server or something, it would be pretty easy.

@pcarranza
Copy link
Contributor Author

Yip, will do it

@smellsblue
Copy link
Contributor

Awesome! Looks good to me! Once you merge this in, I'll update documentation branch with the changes.

@pcarranza
Copy link
Contributor Author

Ah, cool, I'll just do it.

@pcarranza pcarranza merged commit da2f3d4 into rubygems:master Oct 13, 2015
@indirect
Copy link
Member

Awesome. We can probably just pass through -h/--host, -p/--port and -b/--bind directly to Puma? I know it supports all of those things. And I'm 👍 on supporting binding to unix sockets.

@pcarranza
Copy link
Contributor Author

I don't think that would be a problem, this was just attacking the configuration system.

I'll give it a spin later.

@smellsblue smellsblue mentioned this pull request Oct 14, 2015
@smellsblue
Copy link
Contributor

I've been thinking about command line config for a while... I put my thoughts into #30. Also, the new bind option already is a pass through to Puma, should we also support host and port though? I ask because from the Puma project, it looks like the bind option is preferred over host and port.

Digging into the code a bit, the command line options for Puma doesn't actually have a host option, and the port option acts effectively like the bind option behind the scenes. While there is no --host option, I think the config DSL supports it.

Thoughts @indirect, @pcarranza?

@indirect
Copy link
Member

I must have been thinking of the config DSL. It's fine with me to only support bind and port on the command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants