Pull all the gems #48
Conversation
| method_option :latest, :type => :boolean, :default => false, :desc => | ||
| "Only fetch the latest specs" | ||
| method_option :server_url, :type => :string, :default => "http://localhost:9292", :desc => | ||
| "Gemstash server url" |
There was a problem hiding this comment.
If I'm reading the code right, it looks like this is the upstream URL, not the Gemstash URL. If that's the case, that seems like it conflicts with the task description discussing the default upstream. If this is the upstream, I think it should probably be nil by default, so the task description will be correctly pulling from the default upstream when this is nil (which may require some tweaks to the code).
There was a problem hiding this comment.
No, it is not the upstream url, I do create an Upstream just to reuse the object with the client (https://github.com/bundler/gemstash/pull/48/files#diff-b6f92f551dd149bd7013ca6f7f0fd7a2R17)
What this does is create an HTTPClient and start requesting the head of the gems to gemstash without using any upstream path, so it downloads those from the default upstream. This process will not make any call to rubygems.org directly.
All this does is fake a client for every gem version there is in the specs file.
pcarranza
force-pushed
the
pull-all-the-gems
branch
from
7cb7af7
to
7c65707
Compare
pcarranza
force-pushed
the
pull-all-the-gems
branch
from
7c65707
to
312a73e
Compare
|
Thanks for the feedback. Next step, I'll give it a spin to use the |
|
At this point I'm still using head to download the gems. What would be left now is extracting the gem fetching and storing out of the upstream source so I can build one and not use the server. As is it is capable of fetching all the gems (all, prerelease and latest) just that it requires gemstash to be there to hit it. |
| @@ -313,11 +322,86 @@ Show what version of Gemstash you are using. | |||
| ### Usage | |||
|
|
|||
| ``` | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
(Um, is this a Git conflict marker?) Just a fan reading cool code, and I noticed it.
This fixes #18 by adding a thor client to run this process.
Check the reference documentation for details on how to use it.