Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] configs - cannot add multiple file on the same service_id #1000

Closed
2 tasks done
ardhiatno opened this issue Mar 21, 2024 · 3 comments
Closed
2 tasks done

[BUG] configs - cannot add multiple file on the same service_id #1000

ardhiatno opened this issue Mar 21, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ardhiatno
Copy link

What happened?

If i try to add a new file on configs page the second file is overriding service_id of the first file to Null.

Solution :
2024-03-21 17_02_48-bunkerweb_src_ui_src_ConfigFiles py at master · bunkerity_bunkerweb — Mozilla Fi
Move line 59

path_exploded = root.split("/")

after for loop line 60

How to reproduce?

  1. Open Configs Page
  2. Add 1st file to service
  3. Add 2nd file to service
  4. The 1st file is moved to upper folder, in database the service_id on 1st file is changed to Null

Configuration file(s) (yaml or .env)

No response

Relevant log output

No response

BunkerWeb version

1.5.5

What integration are you using?

Docker

Linux distribution (if applicable)

Rocky Linux 9.3

Removed private data

  • I have removed all private data from the configuration file and the logs

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ardhiatno ardhiatno added the bug Something isn't working label Mar 21, 2024
@fl0ppy-d1sk
Copy link
Member

Hello @ardhiatno,

Thanks for opening an issue.

We will try to reproduce the bug and fix it in the upcoming release.

Btw @syrk4web we should update the CI/CD tests with a "double config" add.

@TheophileDiot
Copy link
Member

Hi @ardhiatno, a fix have been done for this and should be available in the testing version shortly 😄

@fl0ppy-d1sk
Copy link
Member

Hello @ardhiatno,

Fix is now available in the v1.5.6 release. Thanks for your feedback !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants