Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe it would be better to make jsonToCSV also work like a pure function. #135

Closed
s5s5 opened this issue Jun 23, 2022 · 1 comment
Closed

Maybe it would be better to make jsonToCSV also work like a pure function. #135

s5s5 opened this issue Jun 23, 2022 · 1 comment
Assignees
@Bunlong
Labels
enhancement New feature or request

Comments

@s5s5
Copy link

s5s5 commented Jun 23, 2022

Hi, thanks for your great work, I have a problem when I upgraded from V3 to V4.
I used jsonToCSV as a pure function in V3 and he worked fine, but upgrading to V4, jsonToCSV became a hook, which restricts it and it can't be used in I suggest to put jsonToCSV and some other pure functions without restricting it to a hook.
Thanks.
@Bunlong
Copy link
Owner

Bunlong commented Jun 23, 2022 •
edited
Loading

@s5s5 Okay, I got it. I'm going to add jsonToCSV as a pure function in next version in next week. Thanks!

@Bunlong Bunlong self-assigned this Jun 23, 2022
@Bunlong Bunlong added the enhancement New feature or request label Jun 23, 2022
@Bunlong Bunlong mentioned this issue Aug 7, 2022
Merged
Bunlong added a commit that referenced this issue Aug 13, 2022
@Bunlong
Make readString, readRemoteFile and jsonToCSV as pure function ( #135 )
43e7dfb
@Bunlong Bunlong closed this as completed Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bunlong Bunlong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s5s5 @Bunlong