Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BunqContext class file duplicated #155

Closed
janxb opened this issue Jun 21, 2018 · 2 comments
Closed

BunqContext class file duplicated #155

janxb opened this issue Jun 21, 2018 · 2 comments

Comments

@janxb
Copy link

janxb commented Jun 21, 2018

Steps to reproduce:

  1. look at the source files in master -> /src/Context/

What should happen:

  1. There should only be one file containing class BunqContext, named "BunqContext.php"

What happens:

  1. There are two files containing class BunqContext, named "BunqContext.php" and "bunqContext.php"

Extra info:

This issue seems fixed in the develop branch, but as it is not in master, composer is still complaining about this. Maybe you can remove the duplicated file from master and build a new version containing this fix?

bunqcontext-class-duplicated

@OGKevin
Copy link
Contributor

OGKevin commented Jun 22, 2018

Yes, this will be fixed in the 1.0.0 release, however for the 1.0.0 release i want to release all the SDK's at the same time.

Is there a reason why this can not wait until the release and should be hotfixed ?

duplicate of #114

@janxb
Copy link
Author

janxb commented Jun 29, 2018

Sorry for the late response. If this issue will be fixed, it's enough. No need for a hotfix. Thanks for your work! :) I will keep this issue open, maybe you can close it when the new version of the SDK including the fix has been released.

@OGKevin OGKevin closed this as completed Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants