Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error in the interactive installer when no allowed IP is given #79

Closed
mbernson opened this issue Dec 7, 2017 · 1 comment
Closed

Comments

@mbernson
Copy link
Contributor

mbernson commented Dec 7, 2017

Steps to reproduce:

  1. Run vendor/bin/bunq-install
  2. Enter no value for the allowed IP, just hit return

What should happen:

  1. The configuration is generated

What happens:

  1. The script gives a fatal error

Logs

PHP Fatal error:  Uncaught TypeError: Argument 1 passed to bunq\Util\InstallationUtil::formatIps() must be of the type string, null given, called in /Users/mbernson/bunqtest/vendor/bunq/sdk_php/src/Util/InstallationUtil.php on line 88 and defined in /Users/mbernson/bunqtest/vendor/bunq/sdk_php/src/Util/InstallationUtil.php:193
Stack trace:
#0 /Users/mbernson/bunqtest/vendor/bunq/sdk_php/src/Util/InstallationUtil.php(88): bunq\Util\InstallationUtil::formatIps(NULL)
#1 /Users/mbernson/bunqtest/vendor/bunq/sdk_php/bin/bunq-install(16): bunq\Util\InstallationUtil::interactiveInstall()
#2 {main}
  thrown in /Users/mbernson/bunqtest/vendor/bunq/sdk_php/src/Util/InstallationUtil.php on line 193

Fatal error: Uncaught TypeError: Argument 1 passed to bunq\Util\InstallationUtil::formatIps() must be of the type string, null given, called in /Users/mbernson/bunqtest/vendor/bunq/sdk_php/src/Util/InstallationUtil.php on line 88 and defined in /Users/mbernson/bunqtest/vendor/bunq/sdk_php/src/Util/InstallationUtil.php on line 193

TypeError: Argument 1 passed to bunq\Util\InstallationUtil::formatIps() must be of the type string, null given, called in /Users/mbernson/bunqtest/vendor/bunq/sdk_php/src/Util/InstallationUtil.php on line 88 in /Users/mbernson/bunqtest/vendor/bunq/sdk_php/src/Util/InstallationUtil.php on line 193

Call Stack:
    0.0003     354664   1. {main}() /Users/mbernson/bunqtest/vendor/bunq/sdk_php/bin/bunq-install:0
    0.0044     677128   2. bunq\Util\InstallationUtil::interactiveInstall() /Users/mbernson/bunqtest/vendor/bunq/sdk_php/bin/bunq-install:16
    9.4677    1736472   3. bunq\Util\InstallationUtil::formatIps() /Users/mbernson/bunqtest/vendor/bunq/sdk_php/src/Util/InstallationUtil.php:88

Extra info:

  • Error occurred on PHP 7.0.26, fix tested on PHP 7.0.26

See PR #78

@OGKevin
Copy link
Contributor

OGKevin commented Dec 7, 2017

Closing this issue as #78 has been merged.

@mbernson thanks for still creating the issue 👍.

@OGKevin OGKevin closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants