Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameters to constructor  #55

Closed
OGKevin opened this issue Dec 19, 2017 · 1 comment
Closed

Add optional parameters to constructor  #55

OGKevin opened this issue Dec 19, 2017 · 1 comment

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Dec 19, 2017

Steps to reproduce:

  1. Take a look at the objects with optional parameters
  2. Try and set these parameters

What should happen:

  1. These parameters can be set via constructor

What happens:

  1. These parameters must be set after constructing the object via setters

Logs

  • Logs no logs

Extra info:

References

@OGKevin OGKevin added this to the 0.13.1 milestone Dec 19, 2017
@OGKevin OGKevin self-assigned this Dec 19, 2017
@OGKevin OGKevin modified the milestones: 0.13.1, 0.13.0 Jan 5, 2018
@OGKevin OGKevin modified the milestones: 0.13.0, 0.13.5 Mar 27, 2018
@OGKevin OGKevin added this to To do in 1.0.0 - SDK via automation Mar 27, 2018
@OGKevin
Copy link
Contributor Author

OGKevin commented Apr 11, 2018

This has been implemented in 302a829

def __init__(self, type_=None, value=None, name=None):
"""
:param type_: The alias type, can be: EMAIL|PHONE_NUMBER|IBAN.
:type type_: str
:param value: The alias value. Phone number are formatted conform E.123
without spaces (e.g., +314211234567).
:type value: str
:param name: The alias name. Only required for IBANs.
:type name: str
"""
self.type_ = type_
self.value = value
self.name = name

@OGKevin OGKevin closed this as completed Apr 11, 2018
1.0.0 - SDK automation moved this from To do to Done Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1.0.0 - SDK
  
Done
Development

No branches or pull requests

1 participant