Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bunq-sdk 0.12.4 package on PyPI contains code from 0.13.0 #88

Closed
Ch00k opened this issue Apr 10, 2018 · 4 comments
Closed

bunq-sdk 0.12.4 package on PyPI contains code from 0.13.0 #88

Ch00k opened this issue Apr 10, 2018 · 4 comments
Labels
Projects

Comments

@Ch00k
Copy link

Ch00k commented Apr 10, 2018

Apparently an error has been made while releasing 0.13.0 to PyPI, because the PyPI package with version 0.12.4 now contains code from 0.13.0. This basically breaks everything :(

@OGKevin
Copy link
Contributor

OGKevin commented Apr 11, 2018

Could you provide code to back this up as I could not find any trace of this. I just installed version 0.12.4 from pip and looked the following line:

_USER_AGENT_BUNQ = 'bunq-sdk-python/0.13.0'

As you can see on tag 0.13.0 it shows the correct version. While on the package 0.12.4 installed via PIP it shows

tmp ⍉ ➜ PIPENV_VENV_IN_PROJECT=1 pipenv --python 3.6 install bunq-sdk==0.12.4
sdk ⍉ ➜ cat client.py | grep AGENT
    HEADER_USER_AGENT = 'User-Agent'
    _USER_AGENT_BUNQ = 'bunq-sdk-python/0.12.4'
            cls.HEADER_USER_AGENT: cls._USER_AGENT_BUNQ,
sdk ➜

So seeing that this is correct it seems highly unlikely that there will be other code thats not suppose to be there 🤔.

Unless im missing something. So please could you provide a code snippet that you think should not be there so I can further investigate.

@Ch00k
Copy link
Author

Ch00k commented Apr 11, 2018

Yeah, sorry for not being clear enough. Apparently, not the whole package code was updated. To reproduce:

  1. Download bunq_sdk-0.12.4-py3-none-any.whl from this page.
  2. Unzip the file
  3. Look into the file bunq/sdk/model/generated/endpoint.py - it contains from 0.13.0 instead of 0.12.4

@OGKevin
Copy link
Contributor

OGKevin commented Apr 11, 2018

😅 you're right. I have no idea how this is possible. Sucks that pip doest just use GitHub like the other package managers 😔

For now, I would suggest you to use pip to install directly from GitHub as explained here

@OGKevin
Copy link
Contributor

OGKevin commented Apr 29, 2018

As I cant seem to override the package from pypi and also have no clue how it even got overwritten. I will host the .gz file on GitHub release.

You can build it locally your self running the following:

$ git checkout 0.12.4
$ python setup.py sdist
$ cd dist/

in there you will find the build.

Closing the issue for now.

@OGKevin OGKevin closed this as completed Apr 29, 2018
@OGKevin OGKevin added the bug label Apr 29, 2018
@OGKevin OGKevin added this to To do in 1.0.0 - SDK via automation Apr 29, 2018
@OGKevin OGKevin added this to the 0.13.5 milestone Apr 29, 2018
@OGKevin OGKevin moved this from To do to open PR in 1.0.0 - SDK Apr 29, 2018
@OGKevin OGKevin moved this from open PR to Done in 1.0.0 - SDK Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
1.0.0 - SDK
  
Done
Development

No branches or pull requests

2 participants