App crashes when updating obsolete formulae

[cweirup]

When I clicked the "Update" button in the Outdated items section of the main screen, the app crashed and sent me back to Xcode. I've attached the output from the Console.

To recreate:

• You will need at least 1 outdated package.
• Build and launch app.
• Click the "Update" button under the outdated package section in Homebrew Status. The issue happens if "Outdated packages" is expanded or not.

The error in the Console is:

SwiftUI/EnvironmentObject.swift:82: Fatal error: No ObservableObject of type UpdateProgressTracker found. A View.environmentObject(_:) for UpdateProgressTracker may be missing as an ancestor of this view.
2023-02-26 22:14:22.612178-0500 Cork[8331:11138509] SwiftUI/EnvironmentObject.swift:82: Fatal error: No ObservableObject of type UpdateProgressTracker found. A View.environmentObject(_:) for UpdateProgressTracker may be missing as an ancestor of this view.

Based on a bit of playing around, I believe you may need to add the Environment Object to the ContentView in CorkApp:

            ContentView()
                .environmentObject(appState)
                .environmentObject(brewData)
                .environmentObject(availableTaps)
                .environmentObject(selectedPackageInfo)
                .environmentObject(updateProgressTracker)
                .onAppear
                {
                    NSWindow.allowsAutomaticWindowTabbing = false
                }

I've also included screenshots of the screen I've referenced and what I see in Xcode. Let me know if you need more info.

Issue - App Crashes Updating Formulae - Console Output.txt

[buresdv]

Your suggestion was right. Try the newest code from the main branch, I tried to update my packages and it worked with no crash.

[buresdv]

There's still one problem that I will have to fix: when you update the packages, the UI doesn't update. I logged it as a bug.

[cweirup]

I've confirmed that the update fixed the crashing problem. Thanks!

[buresdv]

Great, I'll close the issue.