-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance result alert's width too large #270
Comments
Hey, I'll take it upon myself, make me assignees, pls |
@buresdv, check mr👆🏻pls |
Fixed by #271 |
Reopening due to padding bug. @rishatl when there's a lot of content, the top and bottom padding breaks in your implementation (which is now on the branch Would you mind having a look at it? |
@buresdv Removing |
@rishatl that does fix the padding, but now, most of the text is missing: Also, you can expand the sheet to a ludicrous size, which looks bad 😅 I suppose the |
@buresdv |
The text was supposed to be shortened, but that was causing crashes (#173). Would it be possible to shorted the text, allow the sheet to expand, but forbid it from expanding indefinitely? |
I propose this solution - a limit on the maximum size with the ability to expand only vertically if there is a lot of text. .frame(maxWidth: 800, maxHeight: 800)
}
.padding()
.fixedSize(horizontal: true, vertical: false) |
I think I fixed the underlying problem described in #173. Could you try this branch? https://github.com/buresdv/Cork/tree/fixed-maintenance-sheet |
Since nobody reported any issues, I merged the fix into main (54c9ee2) and will consider this bug fixed by it |
Bug Report
Mandatory Information
If you have a large number of unupdated packages, the alert that is shown after the maintenance check doesn't wrap text and is therefore too wide. It doesn't fit on the screen.
To Reproduce
Expected Behavior
Alert wraps text.
Screenshots
![image](https://private-user-images.githubusercontent.com/34969251/309474959-aacffc0b-9c6a-470f-9ac8-08f087f60255.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwMjM3OTMsIm5iZiI6MTcxOTAyMzQ5MywicGF0aCI6Ii8zNDk2OTI1MS8zMDk0NzQ5NTktYWFjZmZjMGItOWM2YS00NzBmLTlhYzgtMDhmMDg3ZjYwMjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIyVDAyMzEzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNiYmZlZWFmYjNhZDE5NDRjYWQ3NWVlYTczMzZlNjYyOGViYzdmNTg0ODhiNGE3ZmQ3Mjg0MGNmODUxOWFkMzkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.iniUcqmOLKA2qdiLxg9pAi4R55e774_DiN0owL7Zn-g)
System and Cork Information:
Checklist
The text was updated successfully, but these errors were encountered: