Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Brewlet (menu bar app) #96

Closed
sh95014 opened this issue Apr 14, 2023 · 2 comments · Fixed by #97
Closed

Integrate with Brewlet (menu bar app) #96

sh95014 opened this issue Apr 14, 2023 · 2 comments · Fixed by #97
Assignees
Labels
Enhancement New feature or request

Comments

@sh95014
Copy link
Contributor

sh95014 commented Apr 14, 2023

Have you considered integrating with the Brewlet project? Seems like Cork can be a “full UI” that Brewlet can launch for more complex tasks, and there may be code-reuse/sharing opportunities as well.

And if that’s not feasible, consider this a feature request to add a menu bar presence to Cork.

@buresdv
Copy link
Owner

buresdv commented Apr 15, 2023

That's an interesting proposition. I had no idea this project existed.

I've had suggestions to implement menu bar items before, but nobody could ever come up with any ideas about what to put in there. I'm not such a big fan of menu bar apps, so I didn't think about it myself.

I will not have the time to write to the project maintainers myself due to a lot of stuff happening at my job lately, so if you'd be up to writing them a message in my place, it would help me a lot. I think the "full UI" idea you proposed would a great approach.

@buresdv buresdv added the Enhancement New feature or request label Apr 15, 2023
@sh95014
Copy link
Contributor Author

sh95014 commented Apr 15, 2023

Sure. I’ll try to find some time to learn more about both Cork and Brewlet and propose something. But as Brewlet is presumably talking to brew.sh in its own way, maybe adding a menu bar item to Cork is the sensible thing.

UI-wise, I think Brewlet might be trying to do too much in the menu bar. I do like the idea of an icon in the menu bar that indicates updates are available, though…

@sh95014 sh95014 mentioned this issue Apr 16, 2023
@buresdv buresdv linked a pull request Apr 16, 2023 that will close this issue
@buresdv buresdv closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants