Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile_pattern should not use string.lower() or use re.I flag #114

Closed
baby5 opened this issue Apr 8, 2019 · 2 comments
Closed

compile_pattern should not use string.lower() or use re.I flag #114

baby5 opened this issue Apr 8, 2019 · 2 comments

Comments

@baby5
Copy link

baby5 commented Apr 8, 2019

python-readability/readability/readability.py

Line 80 in 3cbede6

return re.compile(u'|'.join([re.escape(x.strip().lower()) for x in elements]), re.U)

class or id attributes may have uppercase
@buriy
Copy link
Owner

buriy commented Apr 8, 2019

You're right. Could you make a PR?

@baby5
Copy link
Author

baby5 commented Apr 30, 2019

@buriy I have made a PR for this

@baby5 baby5 mentioned this issue Apr 30, 2019
Merged
@baby5 baby5 closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@buriy @baby5