Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes string primary keys quotes #117

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

insspb
Copy link

@insspb insspb commented Sep 19, 2023

  • Unquotes all ids, instead of only first one
  • Adds migration to tests, that prevented normal local test run
  • Correctly works with string primary keys with special characters (tested)
  • Correctly works with UUID primary keys (tested)

P. S. I am not big fun of working with unittests, so addition tests are up to you.
P.P.S. I have no configuration to format without black

Fixes #116

@bufke @PetrDlouhy I will be very thankfull if you will be able to release these changes, as I do not like to use custom repositories in own projects. Thank you.

@insspb insspb marked this pull request as draft September 19, 2023 09:35
@insspb insspb marked this pull request as ready for review September 19, 2023 10:10
def clean_name(self):
""" Fake cleaning for tests
"""
"""Fake cleaning for tests"""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Fake cleaning for tests"""
"""
Fake cleaning for tests
"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect quatation of special characters in string primary keys
2 participants