Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple questions about your strategy... #1

Open
richb-hanover opened this issue Jul 22, 2017 · 1 comment
Open

A couple questions about your strategy... #1

richb-hanover opened this issue Jul 22, 2017 · 1 comment

Comments

@richb-hanover
Copy link

richb-hanover commented Jul 22, 2017

These aren't so much issues, but requests for clarification...

  1. creat-react-app has a proxy facility for an api server (as described in https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#proxying-api-requests-in-development) Does this project (express-react-starter) replace the need to have a separate proxy dev server?

  2. create-react-app is still evolving. Do you plan to continue to track create-react-app, and just run their update scripts as needed? Or does using express-react-starter require me to eject my project from the mainline create-react-app?

  3. I found this project from the Medium article. You should include a link to it (https://medium.com/burke-knows-words/introducing-express-react-starter-b6d299206a3a) in the README.md since it's such a good exposition about the project

Thanks!

@burkeholland
Copy link
Owner

What GREAT feedback! OMG I loved it.

  1. This is just create-react-app's proxy
  2. I plan to just stay in sync with create-react-app. While it's just react-scripts under the covers in both places, they could make structural changes that would require me to update this project as well. I thought about turning this into a Yeoman generator, but that doesn't solve the problem either. This is because this project is an opinionated setup as it has to be in order to address the use case.

Thoughts?

  1. Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants