Also consider devices of type Other when trying to find the best device. #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophebiocca
force-pushed
the
fix-best-available-wgpu
branch
from
6ec3df4
to
895bf10
Compare
|
Fixed formatting. |
nathanielsimard
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checksscript has been executed../run-checks.sh all, if that makes any difference. It gets errors due to bad tolerances, but they're identical to those onmain.Related Issues/PRs
Meant to fix issue reported in discord: https://discord.com/channels/1038839012602941528/1059209073784008835/1163541031086723162
Changes
WgpuDevice::BestAvailable fails if there is a device of type Other available and nothing else, as it doesn't consider them.
Testing
Not tested beyond
run-checks. Would probably need some kind of mocking? Would like guidance on how to test this change.