Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ONNX Gather op support #947

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

CohenAriel
Copy link
Contributor

@CohenAriel CohenAriel commented Nov 12, 2023

Pull Request Template

Checklist

  • Confirm that run-checks script has been executed.

Related Issues/PRs

#600

Changes

Added support for ONNX Gather op

Testing

End to end test in burn-import/onnx-tests/tests/onnx_tests.rs and codegen test in burn-import/src/burn/node/gather.rs

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding the new ONNX op!

Currently the CI is failing due to a new Candle lib release. Once this is a fix separated, we need to rebase the PR changes and re-run the CI, then it can be merged.

@antimora
Copy link
Collaborator

OK. I have rebased so that candle-core is fixed on CI.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (322480b) 87.25% compared to head (fc4490d) 87.28%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
+ Coverage   87.25%   87.28%   +0.02%     
==========================================
  Files         486      487       +1     
  Lines       49666    49788     +122     
==========================================
+ Hits        43336    43457     +121     
- Misses       6330     6331       +1     
Files Coverage Δ
burn-import/onnx-tests/build.rs 100.00% <100.00%> (ø)
burn-import/onnx-tests/tests/onnx_tests.rs 100.00% <100.00%> (ø)
burn-import/src/burn/node/base.rs 97.15% <100.00%> (+0.01%) ⬆️
burn-import/src/burn/node/gather.rs 100.00% <100.00%> (ø)
burn-import/src/onnx/dim_inference.rs 68.36% <100.00%> (+0.10%) ⬆️
burn-import/src/onnx/to_burn.rs 90.20% <100.00%> (+0.25%) ⬆️
burn-import/src/onnx/op_configuration.rs 81.02% <80.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antimora
Copy link
Collaborator

OK. CI is passing now.

@nathanielsimard ready to be merged.

@nathanielsimard nathanielsimard merged commit cb4c23b into tracel-ai:main Nov 13, 2023
8 checks passed
@antimora
Copy link
Collaborator

@CohenAriel Thank you for your contribution! It's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants