Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix approximately equal precision issue in test code #954

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix approximately equal precision issue in test code #954

merged 1 commit into from
Nov 13, 2023

Conversation

meteor-lsw
Copy link
Contributor

Pull Request Template

Checklist

  • Confirm that run-checks script has been executed.

Related Issues/PRs

#941

Changes

  • new method assert_approx_eq_diff is used to specify tolerance when approximating equality.

Testing

test in should_diff_cos and should_diff_sin

@meteor-lsw
Copy link
Contributor Author

@nathanielsimard ready for review

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb4c23b) 87.34% compared to head (8cef261) 87.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #954   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files         493      493           
  Lines       50127    50132    +5     
=======================================
+ Hits        43783    43788    +5     
  Misses       6344     6344           
Files Coverage Δ
burn-autodiff/src/tests/cos.rs 100.00% <100.00%> (ø)
burn-autodiff/src/tests/sin.rs 100.00% <100.00%> (ø)
burn-fusion/src/handle.rs 88.81% <100.00%> (ø)
burn-tensor/src/tensor/data.rs 87.74% <100.00%> (+0.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's well done :)

@louisfd louisfd merged commit 2614944 into tracel-ai:main Nov 13, 2023
8 checks passed
@louisfd louisfd mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants