Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete_row(idx) #13

Closed
ac001 opened this issue Jan 4, 2012 · 9 comments
Closed

delete_row(idx) #13

ac001 opened this issue Jan 4, 2012 · 9 comments
Assignees

Comments

@ac001
Copy link

ac001 commented Jan 4, 2012

Currently its not possible to remove a row apart from resizing and in this case the row needs to be at the end..

I have a situation where I need to delete a row in the "middle"..

Keep up the good work Anton ;-)))

@ghost ghost assigned burnash Jan 4, 2012
@burnash
Copy link
Owner

burnash commented Jan 4, 2012

Thank you, Peter, I'm sure we need it in the library!

@jyabrow
Copy link

jyabrow commented Oct 2, 2012

+1 for delete_row(), would come in very handy!

@hippysurfer
Copy link

Hi burnash

I too would like delete_row().

I did take a look at the implementation but I can't find any documentation for the google API at the http level (I can only find their API library documentation, which does have a delete_row function).

Where have you been to find the API specifics, did you reverse engineer it all or is there a reference somewhere that I can read?

Thanks for the library!

Richard

@msuozzo
Copy link
Collaborator

msuozzo commented Oct 10, 2015

Bump. We should add delete_row.

@techguydave
Copy link

Is this ever going to happen?

@seandmatthews
Copy link

I think we need to give him some more time. I mean, it's only been like, four and a half years.

@burnash
Copy link
Owner

burnash commented May 26, 2016

@NotLeet you could always help to make it happen faster. The referenced PR misses a test suite and for now I don't have enough time to write it myself. I'm sure that not every gspread user will be happy if I merge all incoming PRs without any prior testing.

This is a non-commercial, open source project. If you use gspread and need something — please contribute to the project.

@seandmatthews
Copy link

Alright, I created a fork and built on amleczko's work. I added the ability to delete by row numbers, delete a list of rows without it failing silently and wrote some more tests.

I've submitted a PR. It's passing all tests and there's no merge conflicts. #390

@burnash
Copy link
Owner

burnash commented Dec 12, 2016

delete_row() was added in #337, v0.5.0. I will add code from #161 and #390 in future releases. I'm closing this issue.

@burnash burnash closed this as completed Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants