Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do something for historical users :) #22

Closed
p0nce opened this issue Jul 23, 2015 · 7 comments
Closed

Please do something for historical users :) #22

p0nce opened this issue Jul 23, 2015 · 7 comments

Comments

@p0nce
Copy link
Contributor

p0nce commented Jul 23, 2015

It is currently impossible to depend on std.experimental.logger and support compilers based on a 2.066 front-end and those with a 2.067 front-end.

Current chain of bug reports that led to this report:

  1. Compilation error in dependency tharsis-prof 0.5.2 DMD 2.067.1 Circular-Studios/Dash#245
  2. Remove Dub dependencies on Logger d-gamedev-team/gfm#124
  3. Dependencies with non-overlapping compiler specifications are refused dlang/dub#630

A possible solution is suggest by Sönke here: dlang/dub#630

But I'm not sure it would work since in user code one has to write import std.experimental.logger and the module names are the same. Similar names induce module import conflicts.

Perhaps consider changing the module names of the DUB package like this:
std.historical.logger

I'll then be able to update user code to import different modules based on front-end versions.

static if (front-end > 2.066)
    import std.experimental.logger;
else
    import std.historical.logger;

This is breaking change so should be a major SemVer bump.

@burner
Copy link
Owner

burner commented Jul 23, 2015

56da8d0

I created a version 2.066 ;-)

@burner
Copy link
Owner

burner commented Jul 23, 2015

please let me now today or tomorrow if it works, I'm leaving for a 2 week holiday on friday

@p0nce
Copy link
Contributor Author

p0nce commented Jul 23, 2015

Thanks! To test I need the DUB registry to be aware of that last tag.
http://code.dlang.org/packages/logger (currently at 0.3.3)

It's not sure how it will recognize that name with a zero. v2.66 will certainly work otherwise.
(edit: the registry did not take that tag!)

@burner
Copy link
Owner

burner commented Jul 23, 2015

lets see if it takes v2.66 https://github.com/burner/logger/releases

@burner
Copy link
Owner

burner commented Jul 23, 2015

2.66.0 it is

@p0nce
Copy link
Contributor Author

p0nce commented Jul 23, 2015

Looks like it work. Thanks!

@p0nce p0nce closed this as completed Jul 23, 2015
@burner
Copy link
Owner

burner commented Jul 23, 2015

welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants