Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job doesn't fail if SSH Key Passphrase is wrong #37

Closed
olach opened this issue Sep 30, 2022 · 1 comment
Closed

Job doesn't fail if SSH Key Passphrase is wrong #37

olach opened this issue Sep 30, 2022 · 1 comment
Assignees

Comments

@olach
Copy link

olach commented Sep 30, 2022

Recently when I configured a new deploy workflow, I accidentally entered a wrong SSH Key Passphrase.

When the rsync deployment job was running, it was running and running forever. No files was uploaded. No errors was shown. I couldn't figure out why it was not working. I had to terminate the job manually, and the logs showed no error.

After a while I realized that I had entered a wrong Passphrase. After correcting this, the next deployment was working correctly.

So, it seems that if the Passphrase is wrong, the action does not abort or shows any error messages. It just keeps running until I manually abort.

I don't know if this is possible for you to handle in your action or not. Maybe it is a limitation in Rsync. But I just wanted to let you know.

Thanks for a great action!

@Burnett01
Copy link
Owner

Hello @olach thank you very much for your report. I will make sure to investigate this over the weekend.
Greetings, Steve

@Burnett01 Burnett01 self-assigned this Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants