Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hyper dev dependency #1

Closed
viperscape opened this issue Jul 16, 2015 · 4 comments
Closed

remove hyper dev dependency #1

viperscape opened this issue Jul 16, 2015 · 4 comments

Comments

@viperscape
Copy link

Is it possible to remove hyper from the dev dependencies?
Hyper includes openssl which is a pain to build on Windows

Thanks

// Cargo.toml
[dev-dependencies]
hyper = { version = "*" }
@BurntSushi
Copy link
Owner

Yeah, I can do that. But I'll have to get rid of the web.rs example. (I don't think dev dependencies are subject to features.)

@viperscape
Copy link
Author

I didn't realize dev dependencies are used during a benchmark, which is why I ask since I wanted to see what kind of performance it actually had on a modern i7. Instead do you mind publishing your results somewhere? It'd be nice if rust separated out examples with a cargo feature. Something like cargo example would be nice

BurntSushi added a commit that referenced this issue Jul 16, 2015
@BurntSushi
Copy link
Owner

OK, I've added the output of running cargo bench: https://github.com/BurntSushi/chan/blob/master/BENCHMARKS.md

Please keep in mind: http://burntsushi.net/rustdoc/chan/#warning:-performance

@viperscape
Copy link
Author

Great thanks! I'll close this now, keeping the web.rs example is important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants