Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use memory maps ever on mac #36

Closed
BurntSushi opened this issue Sep 23, 2016 · 0 comments
Closed

don't use memory maps ever on mac #36

BurntSushi opened this issue Sep 23, 2016 · 0 comments
Labels
enhancement An enhancement to the functionality of the software.

Comments

@BurntSushi
Copy link
Owner

See this thread for justification: https://news.ycombinator.com/item?id=12567326

We already do custom memory map logic for Windows, so it shoul dbe no problem to do it for Mac too.
@BurntSushi BurntSushi added the enhancement An enhancement to the functionality of the software. label Sep 24, 2016
amsharma91 added a commit to amsharma91/ripgrep that referenced this issue Sep 27, 2016
@amsharma91
Tweak memory maps on darwin.
e0077d4 
Namely, don't automatically pick memory maps on darwin, ever. They
appear slower than standard read calls.

Closes BurntSushi#36.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement to the functionality of the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BurntSushi