Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar is transparent on mobile #18

Closed
ghost opened this issue Apr 18, 2019 · 11 comments
Closed

Sidebar is transparent on mobile #18

ghost opened this issue Apr 18, 2019 · 11 comments

Comments

@ghost
Copy link

ghost commented Apr 18, 2019

Describe the bug
The sidebar appears too clear on mobile (tested with both Firefox and Safari on iOS), which makes it illegible. See screenshots.
I have found it hard to debug sine this doesn't affect my Desktop Firefox when using the "Responsive Design Mode" in the FF developer tools...

Screenshots
Firefox iOS:
FF_iOS

Safari iOS:
Safari_iOS

Firefox desktop in responsive mode:
FF_devtools

User Info (please complete the following information):

  • OS: iOS
  • Browser: Safari + Firefox
  • Version: Latest
@jockebq
Copy link

jockebq commented Jun 14, 2019

Having the same issue! Is there any fix?

@ghost
Copy link
Author

ghost commented Jun 15, 2019

I haven't tried myself yet but I might look into it.

@ghost
Copy link
Author

ghost commented Jun 15, 2019

I had a look with the Safari remote debugger. I don't fully understand what's going on but basically:

.sidebar, .sidebar-head, .user-bg, div[id^=request]:not(#request-input-div) .dropdown-toggle {
    -webkit-backdrop-filter: blur(30px);
    backdrop-filter: blur(30px)
}
  • This section is properly showing up as the computed style of the .sidebar (backdrop-filter is not supported but -webkit-backdrop-filter is applied).
  • However Safari behaves exactly as if this rule did not exist. Deactivating it in the inspector doesn't change the display.
  • But inexplicably, reapplying the rule in the inspector causes the blurred background image to properly show up

So it looks more like a Safari bug than a CSS bug...

That being said, it doesn't mean there aren't any fixes, but right now they're a bit beyond my skills.
I suspect there might be a way to activate the fallback to the section under @supports not (backdrop-filter: blur(30px)) to apply the fallback style that uses a background image instead of blur()...

@ghost
Copy link
Author

ghost commented Jun 15, 2019

Anyway until we can find a real fix, for now my workaround is to define in Organizr's "Custom CSS" section the following:

@media screen and (max-width:767px) {
    .sidebar {
        background: url(https://raw.githubusercontent.com/Burry/organizr-v2-plex-theme/master/images/background/noise.png) center center fixed, url(https://raw.githubusercontent.com/Burry/organizr-v2-plex-theme/master/images/background/blur-light.png) center center / cover no-repeat fixed !important
    }
}

@Burry
Copy link
Owner

Burry commented Jun 16, 2019

@yannouchou Thanks for investigating. Seems like it's an experimental feature that needs some love from the WebKit and Blink teams, but it works well enough on desktop Safari. Released a temporary fix in Version 3 that uses the fallback style with no transparency on mobile.

@Burry Burry closed this as completed Jun 16, 2019
@ghost
Copy link
Author

ghost commented Jun 16, 2019

Thanks @Burry
I kind of suspect that the blur works but is computed before the sidebar slides open, hence when it's over nothingness... which would explain why toggling the rule off/on while the sidebar is opened would fix the issue. But that's just speculation. Anyway, thanks for the fix, I think it's a very reasonable workaround!

@ghost
Copy link
Author

ghost commented Jun 16, 2019

Any idea how to make Organizr see and install the latest version?

@Burry
Copy link
Owner

Burry commented Jun 16, 2019

@causefx will need to approve the PR, but if you want to manually update, you can replace the old Plex.css in Organizr's Dashboard/css/themes/ with the new one.

@causefx
Copy link

causefx commented Jun 16, 2019

Merged! :)

@ghost
Copy link
Author

ghost commented Jun 17, 2019

Hmmm, doesn't seem to fix it for me...
Actually, I even lost the background grain effect from the main page:
IMG_1021

@Burry having a quick look at your fix, didn't you mean @media screen and (max-width: 768px) instead of @media screen and (min-width: 768px) ?

@Burry
Copy link
Owner

Burry commented Jun 17, 2019

🤦‍♂️ Yep it should be max-width instead, will fix when I get home. Though it looks like your phone is still loading the old stylesheet: it was pretty “sticky” for me too even after clearing site data so was hard to test, but here’s what it currently looks like on iOS 13:

Screen shot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants