Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] client does not handle disconnects #6

Open
wzrdtales opened this issue May 29, 2018 · 5 comments
Open

[feature] client does not handle disconnects #6

wzrdtales opened this issue May 29, 2018 · 5 comments

Comments

@wzrdtales
Copy link

This client currently does not handle disconnects, be it just a network error or the complete node fails.

@mickhansen
Copy link
Contributor

The connection is not invalidated for the next request?

@wzrdtales
Copy link
Author

it breaks completely, every subsequent request just throws errors that it can't connect to the server even though it is running again. Only restarting the application helps.

@wzrdtales
Copy link
Author

so once i make a call and no server is available it first throws errors and after that it wont stop throwing on subsequent request. If I however do not make a request while the server is down and it is back available again before the next, for some strange reasons everything works.

We talk by the way about spawning, the handler just silently dies and does nothing anymore forever.

@mickhansen
Copy link
Contributor

The client here is specifically a bit low level and should just start failing once a connection dies as you can just start a new client.

The worker library should be handling reconnects though.

@wzrdtales
Copy link
Author

Actually am using the worker library, somehow targeted the wrong repo 😂 So no still the same. I will move this over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants