Skip to content
This repository has been archived by the owner on Mar 5, 2022. It is now read-only.

Refactor the way to get the path and version paths from an entity #94

Closed
burzum opened this issue Sep 3, 2015 · 4 comments
Closed

Refactor the way to get the path and version paths from an entity #94

burzum opened this issue Sep 3, 2015 · 4 comments
Milestone

Comments

@burzum
Copy link
Owner

burzum commented Sep 3, 2015

The way I implemented it now doesn't require a helper, instead you can now get (any) path directly from the entity. I'm just still not happy with the image versions but I think this should be handled in a similar way. Maybe I'm going to add FileStorageEntity::versionPath('type', $options); or something similar, I guess I'll have to try a few things to figure out a nice way to use that functionality.

I think the version path and filename should be handled by the path builders as well but then they need to become aware of the image processing.

@robertpustulka
Copy link
Contributor

Does #95 intend to fix this?

@burzum
Copy link
Owner Author

burzum commented Sep 9, 2015

Yes

@robertpustulka
Copy link
Contributor

OK, I'm closing this.

@burzum
Copy link
Owner Author

burzum commented Sep 15, 2015

@robertpustulka I'm not yet happy with the code for this :( But I haven't found a better way yet. So your input on this is welcome when you have the time to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants