Scheduled departures #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows consumers of the API to specify how many hours in the future to look for stop times. We prefer using offset instead of allowing the client to pass in raw end time values so that the server remains the source of truth for time. There are cases where the client may have the wrong time information and we still want to provide accurate data to them.
| time + end_time_offset.hour | ||
| end | ||
|
|
||
| DEFAULT_END_TIME_OFFSET = 1 |
There was a problem hiding this comment.
Not totally clear from param name or constant that it's expected to be hours (I think)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @geofflane @rockwood