Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove NODE_ENV variable by default #114

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Jul 15, 2020

Change the default for Environment Deletions setting changed from [] to ["NODE_ENV"]

fixes #39

BREAKING CHANGE:

The default for Environment Deletions setting changed from `[]` to `["NODE_ENV"]`

To restore previous behavior change the setting to `[]`
@UziTech UziTech force-pushed the disable-node_env branch 2 times, most recently from 002ba75 to 744bd73 Compare July 15, 2020 17:22
@UziTech UziTech requested a review from the-j0k3r July 15, 2020 17:34
@UziTech UziTech merged commit 66a9a86 into master Jul 15, 2020
@UziTech UziTech deleted the disable-node_env branch July 15, 2020 21:06
@github-actions
Copy link

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released 📮 Release has been made label Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released 📮 Release has been made
Development

Successfully merging this pull request may close these issues.

[BR] npm i has no effect when using x-terminal
2 participants