Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context-menu items to tree view and tabs #213

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Nov 11, 2020

Adds context menu items to tree-view and tab-bar. When executing from tree-view or tab bar opens terminal in folder of selected item.

This will be a breaking change with the way we determine cwd.

fixes #212
fixes #96

@the-j0k3r
Copy link
Member

Cant say I agree with implementation design, but its better than nothing

@UziTech
Copy link
Member Author

UziTech commented Nov 11, 2020

Ya that is one reason it is still a draft. I was trying to avoid this being a breaking but because of the way we get cwd it might have to be.

@UziTech
Copy link
Member Author

UziTech commented Nov 11, 2020

The only other way I could think of doing this would be to have separate commands for the tree-view and tab-bar context menu but I didn't want to create a whole bunch of x-terminal:open-split-up-context-menu commands.

@the-j0k3r
Copy link
Member

Terminus does this fairly well, maybe thats a starting point.

In all honesty, I cant see any such addition being a non breaking change your right and we agree on this much =)

@UziTech
Copy link
Member Author

UziTech commented Nov 11, 2020

Terminus does this fairly well, maybe thats a starting point.

It doesn't look like terminus does anything with the items selected in tree-view.

@the-j0k3r
Copy link
Member

the-j0k3r commented Nov 11, 2020

But it maps to folder just fine optionally which is the point and does via treeview

Actually I posted a gif of it doing it... let me see if I can find it on here

Here #38 (comment) xterminal vs terminus

@UziTech
Copy link
Member Author

UziTech commented Nov 11, 2020

The "map terminals" feature is different than just changing cwd based on context-menu element. For one the map terminals feature does not work when you want to have multiple terminals open or when you want a terminal to open to a specific folder and keep that terminal open even when changing files in Atom.

@UziTech UziTech force-pushed the tree-view-tabs branch 3 times, most recently from 8cb5684 to 088e606 Compare December 2, 2020 02:11
BREAKING CHANGE: change the way cwd is calculated
@UziTech UziTech marked this pull request as ready for review December 2, 2020 05:53
@UziTech UziTech merged commit 84246bc into master Dec 2, 2020
@UziTech UziTech deleted the tree-view-tabs branch December 2, 2020 16:09
@github-actions
Copy link

github-actions bot commented Dec 2, 2020

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released 📮 Release has been made label Dec 2, 2020
@vivi90
Copy link

vivi90 commented Dec 2, 2020

@UziTech Sorry but it doesn't open the selected folder in the terminal for me. Don't see, what i am doing wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released 📮 Release has been made
Development

Successfully merging this pull request may close these issues.

[FR] Open project folder in terminal Why use the project directory when the cwd is in the project path?[Q]
3 participants