Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency node-pty-prebuilt-multiarch to ^0.10.0 #256

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 8, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
node-pty-prebuilt-multiarch ^0.9.0 -> ^0.10.0 age adoption passing confidence

Release Notes

oznu/node-pty-prebuilt-multiarch

v0.10.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@the-j0k3r
Copy link
Member

image

@renovate renovate bot force-pushed the renovate/node-pty-prebuilt-multiarch-0.x branch from 99845b6 to 8141a0f Compare February 9, 2021 03:24
@UziTech UziTech merged commit 0ad0bf0 into master Feb 9, 2021
@UziTech UziTech deleted the renovate/node-pty-prebuilt-multiarch-0.x branch February 9, 2021 15:18
@UziTech
Copy link
Member

UziTech commented Feb 9, 2021

I made this update a breaking change so people will hopefully know what to expect. 😅

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@the-j0k3r
Copy link
Member

I made this update a breaking change so people will hopefully know what to expect. 😅

Should just work ™️ famous last words. =)

@UziTech
Copy link
Member

UziTech commented Feb 9, 2021

Ya the only issue should be when someone tries to update while still having x-terminal open in atom.

@the-j0k3r
Copy link
Member

That breaks the update and thus expect dragons, frozen install at terminal-name\node_modules, maybe there should be some logic that closes x-terminal when you click update in atom.

Maybe not so trivial.

@UziTech
Copy link
Member

UziTech commented Feb 9, 2021

I wonder if updating or uninstalling from atom deactivates the package first?

Answer: nope.

@the-j0k3r
Copy link
Member

Answer: nope.

Yep its the bane of addons. Probably easier to intercept update call and do it that way, else APM needs to be fixed. That last is less likely to happen any time in the next 500 years. So get your vamp on =)

@the-j0k3r
Copy link
Member

the-j0k3r commented Feb 11, 2021

So heres whats happened on last upgrade 12.x to 13.x.

  1. I closed all terminals and restarted atom, this to ensure terminals arent active anywhere.
  2. triggered the update via Atom for the terminal
  3. observed `~.atom\packages\x-terminal contents removed and waited for about 1 minute
  4. node_modules appears and progress seems to stay there forever (waited 5 minutes)
  5. got fed up with waiting and closed Atom
  6. observed ~\.atom\packages\x-terminal contents re-appear

Upon examination the upgrade was successful, terminal works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants