Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidyquant::geom_candlestick #235

Closed
j-craggy opened this issue Sep 6, 2023 · 6 comments · Fixed by #242
Closed

tidyquant::geom_candlestick #235

j-craggy opened this issue Sep 6, 2023 · 6 comments · Fixed by #242

Comments

@j-craggy
Copy link

j-craggy commented Sep 6, 2023

https://business-science.github.io/tidyquant/reference/geom_chart.html

Warning: The following aesthetics were dropped during statistical transformation: open, high, low, close, y
ℹ This can happen when ggplot fails to infer the correct grouping structure in the data.
ℹ Did you forget to specify a group aesthetic or to convert a numerical variable into a factor?

Used to work, but even the vignette is broken.

@FeyyM
Copy link

FeyyM commented Sep 19, 2023

I experience the very same problem, not only with geom_chart, but also with geom_bar. The irony is that the most basic examples from the tutorial does not show up coerrectly .

Error reported by ggplot:

Error in geom_candlestick():
! Problem while computing stat.
i Error occurred in the 1st layer.
Caused by error:
! (converted from warning) Computation failed in stat_linerange_bc()
Caused by error:
! (converted from warning) The following aesthetics were dropped during statistical transformation:
open, high, low, close, y
i This can happen when ggplot fails to infer the correct grouping structure
in the data.
i Did you forget to specify a group aesthetic or to convert a numerical
variable into a factor?

@j-craggy
Copy link
Author

@mdancho84 probably wants a PR done but I don't know how. I guess the package is broken forever.

@olivroy
Copy link
Contributor

olivroy commented Sep 28, 2023

This is due to ggplot2 3.4.0 https://ggplot2.tidyverse.org/news/index.html?q=dropped_aes#new-features-3-4-0

They added dropped_aes.

I don't know ggproto much. tidyverse/ggplot2#5185 but here is how they fixed it for geom_smooth()

@olivroy olivroy mentioned this issue Sep 29, 2023
@mdancho84
Copy link
Collaborator

This is fixed now. Thanks @olivroy

@olivroy
Copy link
Contributor

olivroy commented Sep 30, 2023

Still an issue, I was wondering if you were able to provide guidance for thst @mdancho84

@mdancho84 mdancho84 reopened this Sep 30, 2023
@mdancho84
Copy link
Collaborator

Will need to investigate. Low priority for me at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants