Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

Support multiple languages #166

Closed
fossecode opened this issue Mar 21, 2020 · 9 comments · Fixed by #169
Closed

Support multiple languages #166

fossecode opened this issue Mar 21, 2020 · 9 comments · Fixed by #169
Assignees

Comments

@fossecode
Copy link
Member

No description provided.

@fossecode fossecode self-assigned this Mar 21, 2020
@adriaandotcom
Copy link
Contributor

I think it's important that issue happens first, because it's likely to cause merge conflicts with other PRs. Maybe after we have a list of translations we do this directly?

@fossecode
Copy link
Member Author

Currently working on it. We should probably at least support english as well.

@ian-starts
Copy link
Contributor

ian-starts commented Mar 21, 2020

@fossecode Need help implementing i18n?

@Kilian
Copy link
Contributor

Kilian commented Mar 21, 2020

We can use the same proposed google sheet to translate to english and dutch, a column each. Then we can use that to expand to other languages too.

@fossecode
Copy link
Member Author

@ian-starts Thanks for asking, I can set up the basic stuff first. It would be great if we could start translating in a google sheet. @michaelmcmillan could you look at translating Norwegian -> English?

@michaelmcmillan
Copy link
Member

michaelmcmillan commented Mar 21, 2020

Yes, I can translate from Norwegian to English. How should I do it? Just branch out, or add i18n?

@fossecode
Copy link
Member Author

Any comments on this approach? #169

Yell out if you have any other thoughts

@fossecode
Copy link
Member Author

@Kilian did you create a spreadsheet?

@Kilian
Copy link
Contributor

Kilian commented Mar 21, 2020

Here's the plan:

  • Here is the google sheet, I'll start copying strings over from the EJS files.
  • There are four columns: KEY, Norwegian, which I'll copy over, and empty Dutch and English
  • Filling in the Dutch and English translation is a free for all:
  1. empty space: click on it so it's locked, find the translation, fill it in, move to the next
  2. filled translation: click on it so it's locked, check if you agree, then make the cell green. If you don't agree, update and someone else will check

This way, translations are seen by at least two people without it being a hassle or blocking.

  • Green translations can be added to the repo. Not sure what the best course of action for that is (considering prevention of merge conflicts on the translation files) but maybe someone has an idea there (like, add the KEY to the sheet first? i dunno)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants