Revert order of completions, first id then text #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always need an id, so it should be the first argument. The following arguments then are optional and can later be used to include e.g. icons or longer descriptions
nightscape
force-pushed
the
revert_argument_order
branch
from
0997cfc
to
1c75ec4
Compare
|
No problem |
buster
added a commit
that referenced
this pull request
Jan 29, 2016
Revert order of completions, first id then text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @buster,
I'd like to do this change before it's too late:
Let's switch the order of arguments that is assumed when reading completions that contain a TAB.
We always need an id, so it should be the first argument. The following arguments then are optional and can later be used to include e.g. icons or longer descriptions.
I've just implemented the caching idea and would like to do this change before anyone starts using the cache and gets surprised because text and id are switched.